Uninstalls ISR service on cam deinit #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `gpio_install_isr_service()` is called when initializing the camera, but on de-initiazlization the ISR service is not uninstalled. This causes an error `gpio_install_isr_service(410): GPIO isr service already installed` when the camera is re-initialized.
me-no-dev
added a commit
that referenced
this pull request
Jun 17, 2024
Change is necessary in order to not stop other GPIO ISR uses that users might have in their code. This would cause an error to be emitted when driver is re-initialized, but it's dismissed in code, so the error will not cause any other change in behavior. cc @AxelLin @wouterdebie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
gpio_install_isr_service()is called when initializing the camera, but on de-initiazlization the ISR service is not uninstalled. This causes an errorgpio_install_isr_service(410): GPIO isr service already installedwhen the camera is re-initialized.